Ignore proc macro stage 1 tests#49366
Closed
Phlosioneer wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
A few tests related to proc-macros fail when performing stage-1 testing. This PR adds // ignore-stage1 to them, along with a FIXME. Original issue: rust-lang#49352 This should (hopefully) be fixed when rust-lang#49219 is merged.
Contributor
Author
|
Closes #49352 |
Contributor
Author
|
I don't understand how ignoring a test can cause other tests to fail...? I'm confused. |
emilyalbini
added
the
S-waiting-on-review
Member
|
Highfive failed to assign a reviewer for this PR. Picking one randomly from the compiler team. r? @eddyb |
eddyb
reviewed
Mar 30, 2018
| // ignore-cross-compile | ||
|
|
||
| // FIXME: The proc-macro tests should work for stage1 when #49219 is merged. | ||
| // See also #49352. |
Member
There was a problem hiding this comment.
You should remove the FIXME - this uses the full compiler API, not proc_macro.
Contributor
Author
|
Meh. This seems like a more complicated issue than I expected, and I still don't really understand the cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few tests related to proc-macros fail when performing stage-1
testing. This PR adds // ignore-stage1 to them, along with a FIXME.
Original issue: #49352
This should (hopefully) be fixed when #49219 is merged.