Closed
Conversation
was v4.0.1 to v4.2.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3524 +/- ##
=======================================
Coverage 74.55% 74.55%
=======================================
Files 286 286
Lines 11022 11022
Branches 1344 1344
=======================================
Hits 8217 8217
Misses 2418 2418
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
imnasnainaec
left a comment
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hahn-kev)
.github/workflows/backend.yml line 35 at r1 (raw file):
deb.debian.org:80 dotnetbuilds.azureedge.net:443 dotnetcli.azureedge.net:443
The bump to 4.2.0 should allow removing the three *.azureedge.net:443 endpoints from this file, no?
Contributor
Author
|
Yeah I think we can remove those now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was v4.0.1 to v4.2.0, this should fix the workflow failures. This was caused by the this
This change is