This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Closed
Conversation
abeatrix
reviewed
Dec 16, 2022
abeatrix
reviewed
Dec 16, 2022
abeatrix
reviewed
Dec 16, 2022
6 tasks
This was referenced Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New base k8s cluster, bootstrapped from our existing non-privileged-create cluster.
Desired artifacts
We will keep the old legacy cluster, kustomize overlays, and Helm around for existing customers. All new customers should use the new base cluster with the new customization mechanism.
An intermediate milestone is probably to generate the existing (soon legacy) manifest using (2) from (1). That would be a good test of (2), as well. See notes section below for commentary on this.
To-do
fsGroupChangePolicytoOnRootMismatch(performance)Notes / outstanding questions
There is the question of how to customize.
replacement:withcreate: truein theory, but it's a bit of a hack and I couldn't get it to workSRC_GIT_SERVERS, which we need to do to eliminate the need for service discovery and therefore elevated permissions to create RBAC objects.Overview of current layout, as of eb28273
new/resources/sourcegraph- the proposed new base cluster. Still need to remove RBAC and convert some deployments (the ones referenced here) to statefulsets. Once RBAC is removed, we'll have to pass shard names through environment variables likeSRC_GIT_SERVERSand our customization mechanism will need a way to do this automatically.new/resources/monitoring- moved all the monitoring stuff into a separate directorynew/k8st- some customization code I copied over from thebl/better-customizebranch. This isn't runnable yet, and we can remove this if we decide to move forward with KustomizeChecklist
Test plan