Skip to content

Conversation

@marcorieser
Copy link
Contributor

@marcorieser marcorieser commented Nov 6, 2025

A year ago, Laravel changed the string Regards to Regards, (note the comma), and since then, the translations shipped by Statamic don't work for that key anymore.

Commit: https://github.com/laravel/framework/pull/52417/files

I've changed the existing ones and kept the translations as they are. But I wonder if we should ship both (with and without the comma), in case some sites rely on that. Additionally, I wonder if we should add a comma to all the translations as well? Let me know.

@jasonvarga
Copy link
Member

ugh

@jasonvarga
Copy link
Member

Since we're requiring Laravel 11.34 as the minimum, and the Regards => Regards, change happens in 11.21, we can safely remove the Regards translation.

But yes, we should include the comma in the translations.

@marcorieser
Copy link
Contributor Author

Added the comma where it seems correct. According to my research (AI), the ones I kept as they are don't add that comma.

@jasonvarga
Copy link
Member

Sounds good. Thanks!

@jasonvarga jasonvarga merged commit 333c9a6 into statamic:5.x Nov 6, 2025
23 checks passed
@marcorieser marcorieser deleted the fix/regards-translations branch November 6, 2025 18:19
@ebeauchamps
Copy link
Contributor

ebeauchamps commented Nov 6, 2025

@marcorieser @jasonvarga

hello there. In Arabic, it seems to me that the comma is not on the right but on the left, and it's not a comma (as seen on google translate):
يعتبر،
without a comma:
يعتبر

I think we have other RTL languages (persian?) but I don't recognize the language code

EDIT: saving the comment has changed the way this is displayed. Weird. Below is what I got from GT

Capture d’écran 2025-11-06 à 21 04 23

@marcorieser
Copy link
Contributor Author

@ebeauchamps You're right regarding the position im arabic, stupid copy/paste mistake (was tired). However, the comma character seems right (at least according to Deepl). Will do a fix-the-fix-pr-pr 😅

@marcorieser
Copy link
Contributor Author

@ebeauchamps TL: DR; The PR should be correct 😁

I just checked with an Arabic-speaking guy, and it looks like GH just displays everything left to right. So when that string is rendered, the comma should end up on the left. I was a bit confused because my local editor automatically switched the string to RTL (so the comma is at the end, the left), but on GH it's LTR again (so the comma is at the end, the right).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants