Forbid whitespace before colon in sudoers tags#155
Closed
0x2b3bfa0 wants to merge 1 commit intosudo-project:mainfrom
0x2b3bfa0:forbid-extra-whitespace-in-tags
Closed
Forbid whitespace before colon in sudoers tags#1550x2b3bfa0 wants to merge 1 commit intosudo-project:mainfrom 0x2b3bfa0:forbid-extra-whitespace-in-tags
sudoers tags#1550x2b3bfa0 wants to merge 1 commit intosudo-project:mainfrom
0x2b3bfa0:forbid-extra-whitespace-in-tags
Conversation
Collaborator
|
In general I try to avoid breaking existing sudoers files. I believe the right thing is to treat this as a doc bug and update the manual so that it is clear that whitespace is allowed before the colon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153, but is a breaking change. Not sure if the issues this pull request can cause would outweigh the benefits.
sudo/INSTALL.md
Lines 18 to 23 in e4ea5ad