Skip to content

Comments

Forbid whitespace before colon in sudoers tags#155

Closed
0x2b3bfa0 wants to merge 1 commit intosudo-project:mainfrom
0x2b3bfa0:forbid-extra-whitespace-in-tags
Closed

Forbid whitespace before colon in sudoers tags#155
0x2b3bfa0 wants to merge 1 commit intosudo-project:mainfrom
0x2b3bfa0:forbid-extra-whitespace-in-tags

Conversation

@0x2b3bfa0
Copy link
Contributor

Closes #153, but is a breaking change. Not sure if the issues this pull request can cause would outweigh the benefits.

Warning
This pull request modifies the parser and updates a generated file. It goes whithout saying that this generated file should be verified as part of the code review process, by running make and verifying that the toke.c files are identical. Reproducible with Flex 2.6.4, from Ubuntu 20.04 repositories.

sudo/INSTALL.md

Lines 18 to 23 in e4ea5ad

If you wish to modify the parser then you will need flex version
2.5.2 or later and either bison or byacc (sudo comes with a
pre-generated parser). You'll also have to run configure with the
--with-devel option or pass DEVEL=1 to make. You can get flex from
https://github.com/westes/flex/. You can get GNU bison from
https://ftp.gnu.org/pub/gnu/bison/ or any GNU mirror.

@millert
Copy link
Collaborator

millert commented Jun 7, 2022

In general I try to avoid breaking existing sudoers files. I believe the right thing is to treat this as a doc bug and update the manual so that it is clear that whitespace is allowed before the colon.

@millert millert closed this Jun 7, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the forbid-extra-whitespace-in-tags branch June 7, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for the sudoers tag specification is oblivious to whitespace

2 participants