[Varnika|Yashna] Fix. IPv6 format is fixed#2083
Closed
VarnikaB wants to merge 2 commits intovalidatorjs:masterfrom
Closed
[Varnika|Yashna] Fix. IPv6 format is fixed#2083VarnikaB wants to merge 2 commits intovalidatorjs:masterfrom
VarnikaB wants to merge 2 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2083 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
requested changes
Oct 20, 2022
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Please add new IP addresses that are invalid to the tests
rubiin
added
needs-tests
🧹 needs-update
Author
|
I have added the test cases |
Author
|
I have added the test cases could you please approve it soon. |
rubiin
approved these changes
Mar 28, 2024
rubiin
added
🧹 needs-update
Member
|
Can fix the merge conflict, other than that, LGTM. Thanks for your contrib! |
profnandaa
added
the
mc-to-land
4 tasks
Member
|
Closing this in favour of #2453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the invalid IPv6 address format:
as invalid
Checklist
"fixes #2039"