-
Notifications
You must be signed in to change notification settings - Fork 14
py(deps) libvcs 0.34.0 -> 0.35.0 #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a changelog entry to document this dependency update.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 16 16
Lines 919 919
Branches 137 137
=======================================
Hits 773 773
Misses 93 93
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Changes
py(deps) libvcs 0.34.0 -> 0.35.0
Internally, this libvcs will use
text=Truein subprocess, and deal only with unicode. Before this change, handling bytestrings was supported.Summary by Sourcery
Chores: