Skip to content

Comments

feat(runtime-vapor): support render block in createDynamicComponent#14213

Merged
edison1105 merged 1 commit intominorfrom
edison/feat/dynamicComponentSupportBlock
Dec 17, 2025
Merged

feat(runtime-vapor): support render block in createDynamicComponent#14213
edison1105 merged 1 commit intominorfrom
edison/feat/dynamicComponentSupportBlock

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 07:35
@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/feat/dynamicComponentSupportBlock

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.9 kB 17.3 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.3 kB 35.6 kB 32 kB
createVaporApp 42.3 kB 15.6 kB 14.2 kB
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 71.9 kB 27.2 kB 24.8 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14213
npm i https://pkg.pr.new/@vue/compiler-core@14213
yarn add https://pkg.pr.new/@vue/compiler-core@14213.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14213
npm i https://pkg.pr.new/@vue/compiler-dom@14213
yarn add https://pkg.pr.new/@vue/compiler-dom@14213.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14213
npm i https://pkg.pr.new/@vue/compiler-sfc@14213
yarn add https://pkg.pr.new/@vue/compiler-sfc@14213.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14213
npm i https://pkg.pr.new/@vue/compiler-ssr@14213
yarn add https://pkg.pr.new/@vue/compiler-ssr@14213.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14213
npm i https://pkg.pr.new/@vue/compiler-vapor@14213
yarn add https://pkg.pr.new/@vue/compiler-vapor@14213.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14213
npm i https://pkg.pr.new/@vue/reactivity@14213
yarn add https://pkg.pr.new/@vue/reactivity@14213.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14213
npm i https://pkg.pr.new/@vue/runtime-core@14213
yarn add https://pkg.pr.new/@vue/runtime-core@14213.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14213
npm i https://pkg.pr.new/@vue/runtime-dom@14213
yarn add https://pkg.pr.new/@vue/runtime-dom@14213.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14213
npm i https://pkg.pr.new/@vue/runtime-vapor@14213
yarn add https://pkg.pr.new/@vue/runtime-vapor@14213.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14213
npm i https://pkg.pr.new/@vue/server-renderer@14213
yarn add https://pkg.pr.new/@vue/server-renderer@14213.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14213
npm i https://pkg.pr.new/@vue/shared@14213
yarn add https://pkg.pr.new/@vue/shared@14213.tgz

vue

pnpm add https://pkg.pr.new/vue@14213
npm i https://pkg.pr.new/vue@14213
yarn add https://pkg.pr.new/vue@14213.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14213
npm i https://pkg.pr.new/@vue/compat@14213
yarn add https://pkg.pr.new/@vue/compat@14213.tgz

commit: 536f133

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for render blocks in createDynamicComponent by checking if the getter value is already a Block before attempting to resolve and create a component.

Key Changes:

  • Imports isBlock utility from block module
  • Adds conditional check to return the value directly if it's already a Block instead of processing it through resolveDynamicComponent and createComponentWithFallback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 force-pushed the edison/feat/dynamicComponentSupportBlock branch from e6a1a81 to 536f133 Compare December 17, 2025 09:30
@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 17, 2025
@edison1105 edison1105 merged commit ddc1bae into minor Dec 17, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/feat/dynamicComponentSupportBlock branch December 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant