Conversation
alexander-akait
left a comment
There was a problem hiding this comment.
Also let's add test on 130 code and close for serve (it is already implemented in dev server)
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
- Coverage 95.13% 95.00% -0.13%
==========================================
Files 31 31
Lines 1684 1701 +17
Branches 481 484 +3
==========================================
+ Hits 1602 1616 +14
- Misses 82 85 +3
Continue to review full report at Codecov.
|
af33801 to
859a6c5
Compare
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, let's add tests for build/watch/serve, just enable logging and check on https://github.com/webpack/webpack/blob/main/lib/cache/PackFileCacheStrategy.js#L1263 or you can implement custom plugin and use compiler.cache.hooks.shutdown.tapPromise() with { stage: 9999 } to ensure we will run after cache was stored
b3c5f1f to
5da505a
Compare
5da505a to
52d9a0c
Compare
|
I will add tests |
|
@snitin315 We need improve logic here: we need allow to graceful close and allow immutability disable, my idea - when developer run |
|
Makes sense, I will update it in near future. |
|
@snitin315 hello, let's finish, just copy logic from dev server |
|
@alexander-akait sure 👍🏻 |
| const servers = []; | ||
|
|
||
| const stopAllServers = () => { | ||
| Promise.all( |
There was a problem hiding this comment.
I'd love to make this a variable and passing the variable to the promise expression
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fix #2918
Does this PR introduce a breaking change?
None
Other information
No