Skip to content

Comments

fix: double require problem#3219

Closed
rishabh3112 wants to merge 3 commits intowebpack:masterfrom
rishabh3112:fix/update-bin
Closed

fix: double require problem#3219
rishabh3112 wants to merge 3 commits intowebpack:masterfrom
rishabh3112:fix/update-bin

Conversation

@rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Apr 23, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Fixing double require problem in bin where we check if webpack-cli is installed or not. But were doing a require.resolve, then installing and then again requiring webpack-cli. Later import will create error

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #3219 (47dcc0c) into master (1997a6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3219   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          37       37           
  Lines        1248     1248           
  Branches      352      352           
=======================================
  Hits         1188     1188           
  Misses         54       54           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1997a6e...47dcc0c. Read the comment docs.

@alexander-akait
Copy link
Member

Fixed by #3400, anyway thanks for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants