github(summary): remove preview title and tidy download link#383
Merged
crazy-max merged 2 commits intodocker:mainfrom Jun 26, 2024
Merged
github(summary): remove preview title and tidy download link#383crazy-max merged 2 commits intodocker:mainfrom
crazy-max merged 2 commits intodocker:mainfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
changed the title
|
Looks good. But the semicolon looks a bit odd. Why don't we just say |
Member
Author
semicolon was to link closely related independent clauses but dash seems to be a better alternative for readability while giving a slight emphasis on the additional information about the build record: WDYT @dvdksn? |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
summary-rm-preview-title
branch
from
d292d8b to
9853314
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: https://github.com/docker/actions-toolkit/actions/runs/9660565445?pr=383#summary-26646445706
Before
After