Skip to content

Comments

buildx: fix resolveRefs for bake#395

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:bake-fix-resolveRefs
Jul 2, 2024
Merged

buildx: fix resolveRefs for bake#395
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:bake-fix-resolveRefs

Conversation

@crazy-max
Copy link
Member

we should return undefined if no ref has been found otherwise following cond https://github.com/docker/bake-action/blob/ff7b24e38552946f89b1398525bf9ec25e6de60e/src/main.ts#L212-L214 is always true and seeking refs in local state would never be done.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review July 2, 2024 10:12
@crazy-max crazy-max merged commit 931b62d into docker:main Jul 2, 2024
@crazy-max crazy-max deleted the bake-fix-resolveRefs branch July 2, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant