Merged
Conversation
119e857 to
62f4010
Compare
This was referenced Dec 12, 2020
|
This looks right to me 👍 |
Collaborator
Author
|
Published in v14.0.0 🎉 |
This was referenced Mar 15, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, this is a slightly naive implementation, but I think it's pretty good. If there's a
@charsetanywhere in the CSS, move it to the top of the output and apply it to everything. If there are multiple@charsets, compare them. If they're all the same, just use one. If they're different, there's no way we can put all of these in one file, so error out. If you legitimately need to import files with different charsets, you can use thepluginsorloadoption to add logic to convert all your files to a single encoding that matches the entry point.Also added checks to ensure that
@charsetcomes first, warn the user if this isn't the case.Technically a breaking change due to adding the error and warning cases.
Attn @SLKnutson