[PHP84] Deprecated annotation to Deprecated attribute

[peterfox]

Changes

• Adds a new DeprecatedAnnotationToDeprecatedAttributeRector rule
• Adds tests for DeprecatedAnnotationToDeprecatedAttributeRector
• Adds DeprecatedAnnotationToDeprecatedAttributeRector to the PHP 84 config
• Adds the DEPRECATED_ATTRIBUTE constant

Why

Pretty self explanatory. This just moves the annotation to an attribute as is the case for a lot of things in the PHP world now. The attribute was added in PHP 8.4.

-/**
-* @deprecated 1.0.0 Use SomeOtherClass instead
-*/
+#[\Deprecated(message: 'Use SomeOtherClass instead', since: 1.0.0)]
class SomeClass
{
}

[TomasVotruba]

Thanks Peter 👍

How is the attribute supporting doing in PHPStan https://github.com/phpstan/phpstan-deprecation-rules ?
How's the PHPStorm support for in-code feedback?

We don't want to break those 2, as that's the main benefit of @deprecated in the code.

[peterfox]

Thanks Peter 👍

How is the attribute supporting doing in PHPStan https://github.com/phpstan/phpstan-deprecation-rules ? How's the PHPStorm support for in-code feedback?

We don't want to break those 2, as that's the main benefit of @deprecated in the code.

@TomasVotruba it appears I got a head of myself 😓 PHPStan doesn't seem to support it, nor does PHPStorm.

Equally only till testing it more did I realise that the attribute only works with Functions/Class Methods/Constants, so it's a bit poor compared to the annotation.

Happy to shelve this PR until the attribute is more useful.

[TomasVotruba]

Thank you Peter 🥳 Let's ship it

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.