[php 8.0] Check if class is an attribute in AnnotationToAttributeRector, to avoid non-attribute bug#6954
Merged
TomasVotruba merged 1 commit intomainfrom Jun 2, 2025
Merged
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-skip-non-attribute
branch
from
883079b to
9dc6f52
Compare
…or, to avoid non-attribute bug
TomasVotruba
force-pushed
the
tv-skip-non-attribute
branch
from
ce1b856 to
1ec4d22
Compare
samsonasik
reviewed
Jun 3, 2025
| @@ -1,37 +0,0 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
I will look up on these removed tests and make it work again, ensuring no regression in the future, it seems it missing target stubs in exact source file
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.