Skip to content

Comments

fix: don't pass external modules to the manualChunks function#5068

Merged
lukastaegert merged 2 commits intorollup:masterfrom
TrickyPi:fix/5067
Jul 17, 2023
Merged

fix: don't pass external modules to the manualChunks function#5068
lukastaegert merged 2 commits intorollup:masterfrom
TrickyPi:fix/5067

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jul 15, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5067

Description

I changed some code in PR #5050, so it causes that external modules are passed to the manualChunks function. This PR reverts it back.

@vercel
Copy link

vercel bot commented Jul 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 6:15pm

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #5068 (0cc989c) into master (fecf0cf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5068      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files         226      226              
  Lines        8357     8356       -1     
  Branches     2293     2293              
==========================================
- Hits         8271     8270       -1     
  Misses         31       31              
  Partials       55       55              
Impacted Files Coverage Δ
src/Bundle.ts 100.00% <100.00%> (ø)

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lukastaegert lukastaegert added this pull request to the merge queue Jul 17, 2023
Merged via the queue into rollup:master with commit 0655bd6 Jul 17, 2023
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.26.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollup 3.26.2 breaks Nitro's Deno builds

3 participants