Avoid throwing exception when receiving invalid SqlNotificationInfo value#1378
Merged
cheenamalhotra merged 1 commit intodotnet:mainfrom Nov 17, 2021
johnnypham:SqlNotificationInfo1376
Merged
Avoid throwing exception when receiving invalid SqlNotificationInfo value#1378cheenamalhotra merged 1 commit intodotnet:mainfrom johnnypham:SqlNotificationInfo1376
cheenamalhotra merged 1 commit intodotnet:mainfrom
johnnypham:SqlNotificationInfo1376
Conversation
johnnypham
changed the title
ascott18
approved these changes
Nov 9, 2021
ascott18
left a comment
ascott18
left a comment
There was a problem hiding this comment.
I can confirm after testing that the exception is no longer thrown. The "none" attribute value still comes out as "Unknown" as expected, but without having VS break into an exception when exception settings are all enabled and Just My Code is disabled.
cheenamalhotra
requested review from
DavoudEshtehari,
JRahnama and
Kaur-Parminder
Member
|
Can you add a test case here to cover this code block? |
Contributor
Author
I was unable to reproduce it but this is a server-side bug so it shouldn't be occurring. If it does, we'll avoid throwing an unnecessary exception. |
DavoudEshtehari
approved these changes
Nov 17, 2021
Kaur-Parminder
approved these changes
Nov 17, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1376
When receiving an invalid
SqlNotificationInfovalue, an exception would be thrown because the call toEnum.Parsefails. We can useEnum.TryParseto avoid this. The result will still beSqlNotificationInfo.Unknowneither way.