Add new Attestation Protocol "None" - phase 2#1425
Merged
JRahnama merged 38 commits intodotnet:mainfrom Jan 24, 2022
johnnypham:none-attest
Merged
Add new Attestation Protocol "None" - phase 2#1425JRahnama merged 38 commits intodotnet:mainfrom johnnypham:none-attest
JRahnama merged 38 commits intodotnet:mainfrom
johnnypham:none-attest
Conversation
…and to verify out of range for LocaleId
…rator and GetService for netfx and CreateCommandBuilder for both
Contributor
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
…st/ExceptionTest.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
David-Engel
approved these changes
Jan 10, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/EnclaveDelegate.Crypto.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
Kaur-Parminder
approved these changes
Jan 21, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/EnclaveDelegate.Crypto.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/EnclaveDelegate.Crypto.cs
Show resolved
Hide resolved
...t.Data.SqlClient/tests/FunctionalTests/AlwaysEncryptedTests/ConnectionStringBuilderShould.cs
Show resolved
Hide resolved
...t.Data.SqlClient/tests/FunctionalTests/AlwaysEncryptedTests/ConnectionStringBuilderShould.cs
Outdated
Show resolved
Hide resolved
...t.Data.SqlClient/tests/FunctionalTests/AlwaysEncryptedTests/ConnectionStringBuilderShould.cs
Outdated
Show resolved
Hide resolved
added 2 commits
January 21, 2022 10:51
DavoudEshtehari
approved these changes
Jan 22, 2022
...t.Data.SqlClient/tests/FunctionalTests/AlwaysEncryptedTests/ConnectionStringBuilderShould.cs
Outdated
Show resolved
Hide resolved
…ptedTests/ConnectionStringBuilderShould.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
JRahnama
approved these changes
Jan 24, 2022
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Jan 27, 2022
# Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsEnums.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Jan 27, 2022
# Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsEnums.cs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of feature
Currently, VBS enclaves are supported on-prem and SGX enclaves on Azure VMs. VBS support for Azure is in the works but strong attestation is not possible on Azure VMs due to restrictions against accessing the host machine's Trusted Platform Module (TPM).
A new attestation protocol called "None" will be allowed in the connection string, allowing users to forgo enclave attestation when using VBS enclaves:
Attestation Protocol = NonePhase 2 changes
Attestation Protocol = Nonecan now be added to the connection string. When this is set, theEnclave Attestation Urlproperty is optional (it's required ifAttestation ProtocolisHGSorAAS).Attestation Protocol = Noneonly works when the server returns an enclave type ofVBS. An exception is thrown for any other enclave type.Attestation Protocol = None, theNoneAttestationEnclaveProviderwill be used to set up an enclave session. This provider does not perform attestation and only derives the shared secret required to set up a secure enclave session.-p:BuildSimulator=truewill still work, the driver will simply useNoneAttestationEnclaveProvider. When working with SQL Server in simulator mode, the attestation protocol should now be specified asNoneand notSIM.Attestation Protocol = None. Example run