Fix | Add correct code page for Kazakh collation#584
Merged
cheenamalhotra merged 1 commit intodotnet:masterfrom Jun 10, 2020
Merged
Fix | Add correct code page for Kazakh collation#584cheenamalhotra merged 1 commit intodotnet:masterfrom
cheenamalhotra merged 1 commit intodotnet:masterfrom
Conversation
cheenamalhotra
approved these changes
Jun 1, 2020
Member
cheenamalhotra
left a comment
cheenamalhotra
left a comment
There was a problem hiding this comment.
Backlogging further implementation of 1:1 mapping of Collation <> Encoding for SQL Server supported collations. For coming release, this fix LGTM.
JRahnama
approved these changes
Jun 5, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.cs
Show resolved
Hide resolved
johnnypham
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for GH#576.
The System.Globalization returns 0 code page for Kazakh collation while the SQL Server maps it to 1251. Change the code page to 1251 for Kazakh to keep the consistency.
In the future, we will let the driver maintain all valid mapping between the collation and code page.