Immánuel Fodor

2.0.5 works like a boss on Windows even with messed-up encoding. Bravo! 🙂

Hi Raul,

I’ve checked the changes of 2.0.2 and downloaded the 3 modified files from the WP Trac:
https://plugins.trac.wordpress.org/changeset?old_path=%2Ffast-velocity-minify%2Ftags%2F2.0.1&old=1657113&new_path=%2Ffast-velocity-minify%2Ftags%2F2.0.2&new=1657113&sfp_email=&sfph_mail=

The 2.0.2 update in itself didn’t help at first. Then I checked my theme’s js files in Notepad++ looking for character encoding other than UTF-8 as you suggested. Sadly, all files were utf8, but I converted the problematic plugins.js file to ANSI, just to try it out if any changes happen. KDiff3 instantly showed a couple of differences, eg. copyright symbols and weird whitespaces:

https://www.dropbox.com/s/pk1f9tlpt33idls/converted-to-ansi-copyright-and-other-characters.png?dl=0
https://www.dropbox.com/s/u8mv63jutgcm5n8/converted-to-ansi-weird-whitespace-characters.png?dl=0

It was weird that it showed the weird characters in the utf8 file rather than in the ansi but at least showed that something is wrong somewhere.
I converted the file to different encodings and then back to utf8 but nothing ever helped, the weird characters always stayed there. Although Notepad++ showed as if there was nothing wrong, your plugin always left out the file. No comments showed up in the generated footer js file, PHP Minify just returned the usual empty string instead of === false.

Then I tried out several different utf8 fixer PHP libs but finally I went back to the basics, and stripped out every character from x00 to xFF other than alphanumeric, space, newline and other common symbols in the 7bit ASCII table.

The quick&dirty stripper.php for the record:

<?php

/**
 * Downgrading a file back to 7bit ASCII
 * @see: http://stackoverflow.com/questions/1176904/php-how-to-remove-all-non-printable-characters-in-a-string/1176923#1176923
 * @see: http://www.bluesock.org/~willg/dev/ascii.html
 */
function revert_back_to_7bit_ascii($file) {
    $contents = file_get_contents($file);
    $fixed = preg_replace('/[\x00-\x08\x0b-\x1F\x7F-\xFF]/', ' ', $contents); // additionally keep \x09 the horizontal tab and \x0a the newline char
    file_put_contents($file, $fixed);
}
revert_back_to_7bit_ascii("plugins.js");

If you remember, there were eg. xC2 characters as whitespaces in my js file, now there are none. Diff shows changes invisible to the eye but finally the special characters are replaced with spaces:
https://www.dropbox.com/s/061skc0edvcpb13/diff-to-before-and-after.png?dl=0

After this conversion on my js file, your plugin runs smooth again on my localhost 🙂 and I have the 2.0.2 before anyone else 😀

Looking back, it could be seen as if I would tried to convert the plugin to my needs, however, my files needed to be converted to the plugin instead. Sorry if I took your valuable time.

For the record, I must add that it would be great to implement some sanitization to the input files before processing, like striping out these “broken” or “invisible” control characters, maybe it could achieve better compatibility for other people. I think, this was well done by my modification stripping the h+ and v+ characters with u modifier, so I’d put it back to the code. I understand that you want to force theme/plugin devs to convert their files properly but there are many non-devs out there running their recipe blogs, etc. without knowing anything about their JS files’ encoding, and they just receive errors. If you still insist on no changes to the code, then I’d put some bold text into the plugin’s description, that if any error occurs and nothing seems to help, check the JS files’ character encoding as last solution.

Thank you very much for your help, it was a really exciting Sunday investigating around here and there! 🙂

Cheers, Immánuel

Part 2, an update to my previous comment

I’ve debugged the plugins code, here is what I’ve found.
The fvm_download_and_cache function is able to open the files on Windows as the file_get_contents($f) inside the if (stripos($hurl, $wp_domain) !== false) and if (file_exists($f)) { returns all the files’ contents properly, no prblem about the different slashes. The plugins.js is also there if I echo its contents.
The problem is that the fastvelocity_min_get_js function returns only a ; after processing my plugins.js file. Inside it the .min.js suffixes get excluded, this is how my plugins.min.js is being copied well to the footer.js, as it is not runned through the minification.
Inside the function, the js code is also present after running through the # basic cleaning and minification part but it is empty string after the fastvelocity_min_minify_js_string call.
Inside it, I’ve found that my code disappears after the $minifier->minify() call, it returns empty string, from a var_dump: string(0) "". As you examine the if($min !== false), min is not false by type, but false by “value”. Replacing the !== with != solves the problem. I think it is more elegant to use the empty() function there instead of a logical expression:
http://php.net/manual/en/function.empty.php
For my footer js, here are the expressions evaluations where the fastvelocity_min_minify_js_string is called (from echos in the function):

D:\work\immanuel60.hu\trunk\web/wp-includes/js/underscore.min.js
D:\work\immanuel60.hu\trunk\web/wp-content/plugins/uncode-daves-wordpress-live-search/js/daves-wordpress-live-search.js
(min !== false) - bool(true)
(min != false) - bool(true)
(!empty(min)) - bool(true)
D:\work\immanuel60.hu\trunk\web/wp-content/plugins/i-recommend-this/js/dot_irecommendthis.js
(min !== false) - bool(true)
(min != false) - bool(true)
(!empty(min)) - bool(true)
D:\work\immanuel60.hu\trunk\web/wp-includes/js/mediaelement/mediaelement-and-player.min.js
D:\work\immanuel60.hu\trunk\web/wp-includes/js/mediaelement/wp-mediaelement.min.js
D:\work\immanuel60.hu\trunk\web/wp-content/themes/uncode/library/js/plugins.js
(min !== false) - bool(true)
(min != false) - bool(false) !!! it would return the js instead of the "minified empty string"
(!empty(min)) - bool(false) !!! it would return the js instead of the "minified empty string"
D:\work\immanuel60.hu\trunk\web/wp-content/themes/uncode/library/js/app.js
(min !== false) - bool(true)
(min != false) - bool(true)
(!empty(min)) - bool(true)
D:\work\immanuel60.hu\trunk\web/wp-includes/js/wp-embed.min.js

In my opinion, please consider modifying that if statement in the next release (eg. 2.0.2).

I’ve written a long reply, it doesn’t show up here, what is happening with the support forum!? 😀

Hi Raul,

Thanks for your reply, I did the analysis on my site as you’ve suggested.
Basically, everything is in the same order, no change at first sight in the process order. Then I took a look on the generated files. Hashes are the same in the generated JS and CSS filenames, only the time stamps are different. Then I moved on and looked through the distinct files one by one, and diffed the changes of the 1.5.3 and 2.0.1 generated files. I used the source control’s diff, which highlighted the changes in each file pairs. Only minor changes can be found in all but in my case, the footer-57132dc5 js is completely different. The main difference is that a whole js file is missing! :O I think this causes my site’s disintegration. The missing file is the one ending with library/js/plugins.js, you can find in the logs. This is a plugin file for my theme and the library/js/app.js depends on it. The first console log error also proves this concept:

footer-57132dc5-1494694436.min.js:52 Uncaught TypeError: $(...).tooltip is not a function
    at Object.UNCODE.utils (footer-57132dc5-1494694436.min.js:52)
    at Object.UNCODE.init (footer-57132dc5-1494694436.min.js:296)
    at footer-57132dc5-1494694436.min.js:297
    at footer-57132dc5-1494694436.min.js:297

The error is in the 52nd line, and in the 1.5.3 the plugin.js file’s content were before it, so it is obvious to break now. You can access the js/css files on the live site according to the logs, if you need them for examination.
I’ve attached both cache outputs in the below zip, you can see the differences in the files, too.
https://www.dropbox.com/s/sb4a0zu4v9w9e49/immanuel60.hu.fvm.cache.zip?dl=0
I hope this information can help you solve the issue.

Cheers,
Immánuel

ps. My dev/staging machine is a Windows 10 computer with WAMP installed, HTTPS enabled on localhost, and the virtual server’s name is the same as my live site. In this way, I can use the SSL certs of my live site on localhost and DB migrations are also easy as no need to change any domain names from live to local and vice versa. Changing between the two is done with a clever windows .bat file, so I can remove or add the domain to my Windows’ hosts file wit a double click to route any requests to my laptop, or let it go to the net. I always have Chrome dev toolbar open with Disable Cache enabled. I’ve added this note in case you would be curious how the live domain is in the logs, however it comes from localhost. But I think there is no correlation between my setup or the broken js, the missing file should be there using any machine.

Very kind of you, thanks! 🙂