Conversation
The e2e spec still asserted the pre-rebrand copy ('the post content')
and a placeholder '(s)' pluralization ('1 suggestion(s) found.'), but
the UI strings were updated in a later commit:
- InternalLinksPlugin.tsx now renders 'the content has at least...'
- the suggestions count now uses _n() for proper pluralization,
rendering '1 suggestion found.' for the singular case.
This is what causes the two 'Run E2E tests' CI failures on PR WordPress#887:
Suggest Internal Links button is disabled when there is not enough content
Can use the Internal Link Suggestions Experiment in the block editor
Verified against the actual built plugin (WP Playground preview from
the PR) that the rendered copy matches what this fixes the test to
expect, i.e. the app code is correct and only the test fixture was
stale.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix for the two currently-failing "Run E2E tests" CI checks on WordPress/ai#887:
Suggest Internal Links button is disabled when there is not enough contentCan use the Internal Link Suggestions Experiment in the block editorBoth fail on stale string assertions, not application bugs:
InternalLinksPlugin.tsxwas updated in a later commit to say "the content has at least..." (rebranding away from post-specific terminology), but the e2e spec still asserts the old "the post content has at least..." copy._n()for proper singular/plural handling, rendering"1 suggestion found."— but the spec still asserts the placeholder-style"1 suggestion(s) found.".Testing
5b4ed5d), confirmed both mismatches against the CI failure logs.npm run build) and loaded it into the PR's own WP Playground preview build to independently confirm the actual rendered copy is"Internal Link Suggestions will be available when the content has at least 75 characters."— i.e. the app code is correct and only the test fixture was outdated.npx wp-scripts lint-json the modified spec file passes clean.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Testing PR WordPress#887, diagnosing the CI e2e failures, and writing this fix.
🤖 Generated with Claude Code