-
Notifications
You must be signed in to change notification settings - Fork 165
Create image sub-sizes in additional MIME types using sources for storage.
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felixarntz
merged 37 commits into
trunk
from
feature/142-multiple-mimes-for-image-sizes
Feb 24, 2022
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
0706e81
Add the `sources` property to each image size
mitogh 9c43b89
Fix linting errors from `phpcs`
mitogh 25479a1
Make sure the correct size is updated
mitogh 0f560d8
Merge branch 'trunk' into feature/142-multiple-mimes-for-image-sizes
mitogh 410c124
Update code to use existing WP Core function instead.
mitogh 7a8b0c5
Reorder functions and hooks.
mitogh f71a897
Use a third person verb instead.
mitogh 4b4cbc2
Fix `webp` typo in the extension
mitogh b01be99
Merge branch 'feature/142-multiple-mimes-for-image-sizes' of github.c…
mitogh 4ba9409
Define the right type for the doc block.
mitogh 5321483
Fix syntax error when calling `wp_get_registered_image_subsizes`
mitogh 2bf68f6
Removal of support class no longer required
mitogh de38c2d
Add test images, the images would be used in tests.
mitogh dd13025
Add required methods for the mock Editor.
mitogh 70eeb33
Remove non required conditional on testing method.
mitogh 107db40
Add support for multiple mime types for existing images sizes.
mitogh 975fddd
Include tests for the deletion of an attachment.
mitogh e3c2e3a
Update file to follow `PHPCS` rules.
mitogh 6e3afee
Prevent naming collisions with existing functions.
mitogh 76f1c2f
Replace `array_key_exists` with `isset`
mitogh fba8fab
Replace `array_key_exists` with `isset`
mitogh 7da54dc
Replace `array_key_exists` with `isset`
mitogh 2c37d19
Replace `array_key_exists` with `isset`
mitogh 2c6307f
Fix alignment on dockblock
mitogh 5b5ff6d
Replace `array_key_exists` with `isset`
mitogh 0e94c15
Replace `array_key_exists` with `isset`
mitogh a5b63df
Updates from code review.
mitogh e0b48c4
Fix linting errors
mitogh e996230
Adjust logic and variable names to follow WP Core.
mitogh d708dfd
Fix linting error of alignment
mitogh 061ef31
Remove blank lines.
mitogh 81ea713
Add parenthesis to method references.
mitogh 411efe4
Add parenthesis to method references.
mitogh a2c6815
Update documentation on function return value.
mitogh a2c655c
Update image generation into a single process.
mitogh 38224b0
Fix linting errors for PHP
mitogh acd12f1
Replace `array_key_exists` with `isset` instead.
mitogh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.