Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @chenyukang (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Elizafox
force-pushed
the
issue-52389
branch
from
September 9, 2026 16:01
fd53974 to
dd0f85f
Compare
This comment has been minimized.
This comment has been minimized.
Elizafox
force-pushed
the
issue-52389
branch
from
September 9, 2026 16:13
dd0f85f to
cee7fdc
Compare
This comment has been minimized.
This comment has been minimized.
Elizafox
force-pushed
the
issue-52389
branch
from
September 9, 2026 16:34
cee7fdc to
77d0b37
Compare
chenyukang
reviewed
Sep 11, 2026
| } else if let RibKind::Block(Some(module)) = rib.kind | ||
| && let Ok(binding) = self.cm_mut().resolve_ident_in_scope_set( | ||
| ident, | ||
| orig_ident, |
Member
There was a problem hiding this comment.
You can not just or orig_ident, this program:
#![feature(decl_macro)]
fn main() {
let helper = || "outer local";
{
fn helper() -> &'static str {
"inner item"
}
macro call_helper() {
helper()
}
assert_eq!(call_helper!(), "inner item");
}
}compiled and will find wrong helper with this change:
thread 'main' (57310377) panicked at /tmp/now.rs:12:9:
assertion `left == right` failed
left: "outer local"
right: "inner item"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Member
|
@rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple one-line fix and regression test for macro-generated items within the same block.
Fixes #52389