Skip to content

Add c_buffer_length diagnostic attribute - #162565

Open
JohnTitor wants to merge 1 commit into
rust-lang:mainfrom
JohnTitor:diagnostic-c-buffer-length
Open

Add c_buffer_length diagnostic attribute#162565
JohnTitor wants to merge 1 commit into
rust-lang:mainfrom
JohnTitor:diagnostic-c-buffer-length

Conversation

@JohnTitor

@JohnTitor JohnTitor commented Sep 9, 2026

Copy link
Copy Markdown
Member

An initianl implementation for #148664
Tracking issue: #162563
r? estebank

@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to diagnostic attributes.

cc @mejrs

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2026
@JohnTitor JohnTitor mentioned this pull request Sep 9, 2026
Open
8 tasks
@mejrs

mejrs commented Sep 10, 2026

Copy link
Copy Markdown
Member

This is quite different from what all other diagnostic attributes do (they customize errors that would get emitted regardless) - this is a lint helper.

I'm not opposed to it, but please get a confirmation from the lang team that they're OK with moving the diagnostic namespace in this direction. See #t-lang > extending the diagnostic namespace for prior discussion.

@JohnTitor

JohnTitor commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Ah, sorry about that. Opened a topic here: https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/Extend.20the.20diagnostics.20attr.20for.20a.20lint.20helper/with/623001975

estebank
estebank reviewed Sep 10, 2026
View reviewed changes
Comment thread src/doc/unstable-book/src/language-features/diagnostic-c-buffer-length.md

This is for a future lint described in [#148664](https://github.com/rust-lang/rust/issues/148664).

<!-- FIXME(JohnTitor): descirbe more once a lint is implemented. -->

@estebank estebank Sep 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

View changes since the review

estebank
estebank approved these changes Sep 10, 2026
View reviewed changes

@estebank estebank left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable, r=me after t-lang input.

View changes since this review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnTitor @rustbot @mejrs @estebank