Conversation
rustbot
added
S-waiting-on-author
dianne
commented
Sep 23, 2026
Comment on lines
+29
to
+30
| //~| ERROR type mismatch resolving | ||
| //~| ERROR the size for values of type `RustaceansAreAwesome` cannot be known |
Member
Author
There was a problem hiding this comment.
These extra errors should be removed by #163201
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I can't tell what the failure is supposed to be there. following the instructions to reproduce locally also turns up nothing. I'll just try re-running PR CI |
dianne
force-pushed
the
dyn-satisfies-bounds
branch
from
September 23, 2026 09:29
b4c7073 to
452a7ca
Compare
Member
Author
|
looks like it was nothing. I'm guessing this doesn't need an FCP since it fixes a regression. I don't think it should instantly stabilize anything that wasn't allowed prior to this check being formulated in terms of but to be sure, r? types |
rustbot
added
the
T-types
dianne
marked this pull request as ready for review
September 23, 2026 12:51
rustbot
added
S-waiting-on-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
RustaceansAreAwesomein place ofdyn Traitwhen checking whetherTrait's methods' receivers are dyn-dispatchable.Trait's where-bounds should hold for it.Fixes #161621