Skip to content

Add enclosing item context when pointing at FnMut bound - #163241

Open
estebank wants to merge 2 commits into
rust-lang:mainfrom
estebank:closure-context
Open

estebank wants to merge 2 commits into
rust-lang:mainfrom
estebank:closure-context

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Ensure that we always show the fn (and its enclosing trait/impl if appropriate) when pointing at an FnMut bound:

help: `Fn` and `FnMut` closures require captured values to be able to be consumed multiple times, but `FnOnce` closures may consume them only once
  --> $DIR/fnmut-closure-moving-value.rs:11:14
   |
LL | impl Bar {
LL |     fn f<F>(&self, mut f: F)
LL |     where F: FnMut()
   |              ^^^^^^^

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 24, 2026
@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 21 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Ensure that we always show the `fn` (and its enclosing `trait`/`impl` if appropriate) when pointing at an `FnMut` bound:

```
help: `Fn` and `FnMut` closures require captured values to be able to be consumed multiple times, but `FnOnce` closures may consume them only once
  --> $DIR/fnmut-closure-moving-value.rs:11:14
   |
LL | impl Bar {
LL |     fn f<F>(&self, mut f: F)
LL |     where F: FnMut()
   |              ^^^^^^^
```

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants