Conversation
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Member
|
Overall, this seems to be well-implemented. If it is accepted, there would need to be better diagnostics for this type of of situation. The name of the attribute itself is also not clear imo. I feel obliged to mention that I am not a compiler reviewer and have only acted in an advisory role reviewing restriction PRs. But to repeat what I said on Zulip, I'm not sure this is the right way to go. It would implicitly mean that it wouldn't be permitted to remove the impl restriction anywhere the attribute is present. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original change broke
aho-corasickbecause ofSliceIndexmade future upstream impls opt-in with
#[rustc_coherence_future_impls]whichVaArgSafenow usehttps://rust-lang.zulipchat.com/#narrow/channel/144729-t-types/topic/Impl.20restriction.20sadness/with/626411732