Skip to content

feat: Add documentation for rule limit - #2540

Open
Michael Telgmann (mitelg) wants to merge 1 commit into
mainfrom
feat/hidden-gems-07
Open

Michael Telgmann (mitelg) wants to merge 1 commit into
mainfrom
feat/hidden-gems-07

Conversation

@mitelg

Copy link
Copy Markdown
Member

Summary

Based on https://winkelwagen.de/2026/08/03/shopware-6-hidden-gems-7-shopware-dal-max_rule_prices-the-silent-price-sorting-cutoff/

Big kudos to Fabian Blechschmidt (@Schrank) 🚀 🎉

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant.
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted.
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms.
  • Any required dependent changes in downstream modules have already been merged and published.
  • This pull request is ready for review.

@shopware-dev-docs-connector

shopware-dev-docs-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Completed with success.
Repository: shopware/docs
Commit: d87b52a
Preview: https://developer-documentation-ib1lpnlgc-shopware-frontends.vercel.app
Workflow run: #5407

@mitelg
Michael Telgmann (mitelg) added this pull request to stack #2534 September 22, 2026 15:23
Base automatically changed from feat/hidden-gems-06 to main September 22, 2026 15:27

@bojanrajh Bojan Rajh (bojanrajh) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael Telgmann (@mitelg) Su (@sushmangupta) Micha Hobert (@Isengo1989) Since this is performance-oriented topic, should we move the article from Configurations to Performance section, at the same Guides > Hosting level?

@mitelg

Copy link
Copy Markdown
Member Author

Bojan Rajh (@bojanrajh) increasing the rule limit will decrease the performance. therefore I am not sure, it that would be suitable 😁

@bojanrajh

Copy link
Copy Markdown
Contributor

Copilot Make a decision about last 2 comments - flip a coin. :)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Only a non-blocking documentation nit remains.

Review effort: Lite
Findings: None

What changed in this PR

Adds documentation for Shopware’s max_rule_prices setting, its default limit, configuration override, and performance impact.

Changes:

  • Documents the default 100-rule limit.
  • Adds YAML configuration guidance.
  • Warns about potential listing performance effects.
File Description
guides/​hosting/​configurations/​shopware/​price-rule-limit.md Documents the price-rule calculation limit and configuration example.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Copilot Make a decision about last 2 comments - flip a coin. :)

Tails — let’s keep it under Guides > Hosting > Configurations > Shopware. The page is about changing a Shopware config value, and the performance impact is already called out in the warning.

@sushmangupta Su (sushmangupta) added Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document labels Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants