[6.x] Add missing tooltips to global header - #15234
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds missing tooltips to some of the global header buttons, and cleans up a bit of leftover code along the way.
v-tooltipto the Support button, the "View Site" button and the nav toggle. With the same pattern the layout toggle (MaxWidthButton) already uses.aria-labelto the user dropdown trigger. (No tooltip there on purpose)v-popper--has-tooltipclasses.v-tooltip="version"on the logo.foo="bar"fromProBadge.vue:-)User Menuis the only new string and it should probably be translated. It's screen reader only, so at least a missing translation won't show up anywhere in the UI.Preview:
