[6.x] Show and keep a localized date in the control panel - #15453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15452
The control panel derives a localization's localized fields from
data()->keys(). The date is never indata()(the file driver reads it from the path, the eloquent driver from a column), so a localization that owns its date is always shown as synced, and on the next save the form sends_localizedwithoutdate,update()callsdate(null)and the own date is lost.edit()listsdatewhen the localization has an explicit date and the blueprint's date field is localizable.revisionAttributes()stores no date for a localization whose date is inherited, andmakeFromRevision()clears the date when the revision carries none, so a reopened working copy does not turn an inherited date into an own one.Note: for the eloquent driver the own date only reaches the row with statamic/eloquent-driver#619 (statamic/eloquent-driver#619). Revisions written before this change store the resolved date and restore it as an own date on localizations, as they do today.