module: unflag --experimental-strip-types - #56350
Conversation
|
Review requested:
|
7505688 to
72e089c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56350 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 657 657
Lines 190655 190658 +3
Branches 36582 36584 +2
==========================================
- Hits 168824 168820 -4
- Misses 15008 15011 +3
- Partials 6823 6827 +4
🚀 New features to boost your workflow:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking
|
What about process.features.typescript? Does that also needs changing? |
It works fine, tests are updated (now the default value is 'strip') |
c28ef27 to
d847c32
Compare
It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.
Fixes: nodejs/typescript#17
@nodejs/tsc for visibility
Notable change section:
This change enables the flag
--experimental-strip-typesby default.Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.