Add ui tests for test harness item walk and proc macro input gating - #159319
Open
akintewe wants to merge 2 commits into
Open
Add ui tests for test harness item walk and proc macro input gating#159319akintewe wants to merge 2 commits into
akintewe wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @jackh726 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rust-cloud-vms
Bot
force-pushed
the
coverage-gap-tests
branch
from
July 15, 2026 21:35
e3d1f34 to
93ea130
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These add coverage for two compiler paths that real crates hit constantly but the test suite never exercised. Found by diffing coverage from compiling crates.io crates against the test suite's coverage, then confirmed by putting a panic in the functions and compiling the crates.
These add coverage for two compiler paths that real crates hit constantly but the test suite never exercised. Found by diffing coverage from compiling crates.io crates against the test suite's coverage, then confirmed by putting a panic in the functions and compiling the crates.
Functions covered that the suite previously didn't hit:
<InnerItemLinter as Visitor>::visit_where_predicate,visit_where_predicate_kind,visit_qself,visit_pat_field,visit_anon_const<EntryPointCleaner as MutVisitor>::visit_where_predicate,flat_map_where_predicate,visit_where_predicate_kind,visit_qself,visit_pat_field,flat_map_pat_field<GateProcMacroInput as Visitor>::visit_macro_defFor the test harness case this adds a
harnessrevision totests/ui/unpretty/exhaustive.rsthat compiles it with--test, so the harness expansion visitors walk the complete AST instead of a hand-picked one.-Zunpretty=expandedstops before the analyses that make thehirrevision fail.The second test covers
GateProcMacroInput::visit_macro_def, which only runs when an attribute proc macro is applied to an item containing amacro_rules!definition.r? jackh726