Skip to content

Hint that str search results are in bounds - #160737

Open
SomeFlyingThing wants to merge 2 commits into
rust-lang:mainfrom
SomeFlyingThing:agent/hint-str-find-result-bounds
Open

Hint that str search results are in bounds#160737
SomeFlyingThing wants to merge 2 commits into
rust-lang:mainfrom
SomeFlyingThing:agent/hint-str-find-result-bounds

Conversation

@SomeFlyingThing

Copy link
Copy Markdown
Contributor

It hints that successful find and rfind return à index in bounds

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 8, 2026
@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@JohnTitor

Copy link
Copy Markdown
Member

Given the branch name I guess you used an LLM for this PR, right? As per https://forge.rust-lang.org/policies/llm-usage.html, we don't generally accept LLM-assisted PRs without prior approval, and it should be for a tiny PR.

@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2026
@SomeFlyingThing

Copy link
Copy Markdown
Contributor Author

Given the branch name I guess you used an LLM for this PR, right? As per https://forge.rust-lang.org/policies/llm-usage.html, we don't generally accept LLM-assisted PRs without prior approval, and it should be for a tiny PR.

Yes a LLM was partially used although I reviewed the changes and made the pr myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants