Skip to content

Only use dlltool.exe on MinGW if -Cdlltool is passed - #161050

Open
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:default_no_dlltool
Open

Only use dlltool.exe on MinGW if -Cdlltool is passed#161050
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:default_no_dlltool

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 13, 2026

Copy link
Copy Markdown
Member

The linker used by MinGW now works with ar_archive_writer generated short import libraries too.

Implements rust-lang/compiler-team#1029

r? @mati865

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2026
@mati865 mati865 added the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Aug 13, 2026
Comment thread compiler/rustc_codegen_ssa/src/back/archive.rs Outdated
The linker used by MinGW now works with ar_archive_writer generated short
import libraries too.
@bjorn3
bjorn3 force-pushed the default_no_dlltool branch from 7dda195 to fd82481 Compare August 14, 2026 09:48

@mati865 mati865 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked only the on MCP.

View changes since this review

@mati865 mati865 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants