Skip to content

bootstrap: Allow ./x fix --allow-dirty - #161220

Open
Zalathar wants to merge 2 commits into
rust-lang:mainfrom
Zalathar:allow-dirty
Open

bootstrap: Allow ./x fix --allow-dirty#161220
Zalathar wants to merge 2 commits into
rust-lang:mainfrom
Zalathar:allow-dirty

Conversation

@Zalathar

Copy link
Copy Markdown
Member

This PR forwards --allow-dirty from bootstrap to cargo, making ./x fix more convenient.

This was already possible via ./x fix -- --allow-dirty, but forwarding the argument from bootstrap is more user-friendly.

r? Kobzol (or bootstrap)

@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Zalathar Zalathar changed the title Allow dirty bootstrap: Allow ./x fix --allow-dirty Aug 17, 2026

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense. Left one comment.

View changes since this review

Comment thread src/bootstrap/src/core/builder/cargo.rs Outdated
This was already possible via `./x fix -- --allow-dirty`, but forwarding the
argument from bootstrap is more user-friendly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants