Remove impl DebugWithContext for BorrowckDomain - #161269
Open
nnethercote wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
LLM disclosure: an LLM found this code was unused. I made all the code and text changes myself. |
Only `iterate_to_fixpoint` requires `Domain: DebugWithContext<Self>`; `visit_results` does not. And `Borrowck` is an unusual analysis that never calls `iterate_to_fixpoint`; instead its results are composed from the results of the three sub-analyses.
nnethercote
force-pushed
the
rm-impl-DebugWithContext-for-BorrowckDomain
branch
from
August 18, 2026 02:39
70707a7 to
d51f4d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
iterate_to_fixpointrequiresDomain: DebugWithContext<Self>;visit_resultsdoes not. AndBorrowckis an unusual analysis that never callsiterate_to_fixpoint; instead its results are composed from the results of the three sub-analyses.r? @cjgillot