Skip to content

skip when only one side have side_effects for zip - #161279

Open
im-lunex wants to merge 1 commit into
rust-lang:mainfrom
im-lunex:fix_#161266
Open

skip when only one side have side_effects for zip#161279
im-lunex wants to merge 1 commit into
rust-lang:mainfrom
im-lunex:fix_#161266

Conversation

@im-lunex

@im-lunex im-lunex commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

fixes #161266

  • the debug_assert_eq in zip.rs panics when only one iterator has side effects and its the shorter one. just skip assert when both sides dont have side effects...

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 18, 2026
@rustbot

rustbot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e, tgross35

@workingjubilee

Copy link
Copy Markdown
Member

TrustedRandomAccess + zip wonkiness...

r? @the8472

@rustbot rustbot assigned the8472 and unassigned Mark-Simulacrum Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zip::next_back debug assertion fires when only one side has side effects and it is the shorter side

5 participants