libtest: Allow passing --test-threads and --color multiple times, with later arguments overriding earlier - #161312
Open
joshtriplett wants to merge 2 commits into
Open
libtest: Allow passing --test-threads and --color multiple times, with later arguments overriding earlier#161312joshtriplett wants to merge 2 commits into
joshtriplett wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
added
the
T-testing-devex
Contributor
|
Looks good from my side. Starting fcp for this as it is a one-way door. @rfcbot fcp merge testing-devex |
Collaborator
|
@epage has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rust-rfcbot
added
proposed-final-comment-period
Urgau
reviewed
Aug 18, 2026
Cargo would like to be able to pass `--test-threads=N`, without breaking the ability for the user to do the same and override cargo's value. Currently, the option only allows one instance, failing if it sees multiple. Accept `--test-threads=N` multiple times, and have the last instance win.
Cargo would like to be able to pass a `--color` option, without breaking the ability for the user to do the same and override cargo's value. Currently, the option only allows one instance, failing if it sees multiple. Accept `--color` multiple times, and have the last instance win.
joshtriplett
force-pushed
the
libtest-multi
branch
from
August 18, 2026 22:19
61bf561 to
ef65ece
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo would like to be able to pass these arguments, without breaking the ability for the user to do the same and override cargo's value. Currently, the option only allows one instance, failing if it sees multiple.
Accept
--test-threads=Nand--color=...multiple times, and have the last instance win.