Commit 04d9d74
[deoptimizer] Handle undefined in MaterializeFixedDoubleArray
When V8_ENABLE_UNDEFINED_DOUBLE is enabled, holey double arrays can
store undefined values encoded as Float64::undefined_nan(). During
deoptimization, the translated value for such an element evaluates to
undefined_value.
MaterializeFixedDoubleArray previously assumed that any non-number
element must be the_hole_value, leading to a CHECK failure when
encountering undefined_value.
This CL handles undefined_value under V8_ENABLE_UNDEFINED_DOUBLE by
calling array->set_undefined(i).
Fixed: 546308452
Change-Id: I445ec4fbc09431ef1cced29870eec18895b894fd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8260330
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Marco Vitale <mrcvtl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109271}1 parent 4397869 commit 04d9d74
2 files changed
Lines changed: 35 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2204 | 2204 | | |
2205 | 2205 | | |
2206 | 2206 | | |
| 2207 | + | |
| 2208 | + | |
| 2209 | + | |
| 2210 | + | |
2207 | 2211 | | |
2208 | 2212 | | |
2209 | 2213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
0 commit comments