Skip to content

[DOM] Fix Fragment removeEventListener dropping tracked listeners - #37160

Merged
jackpope merged 1 commit into
mainfrom
fragment-refs/fix-remove-event-listener
Aug 12, 2026
Merged

[DOM] Fix Fragment removeEventListener dropping tracked listeners#37160
jackpope merged 1 commit into
mainfrom
fragment-refs/fix-remove-event-listener

Conversation

@jackpope

@jackpope jackpope commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Removing an unregistered listener used splice(-1), which deleted the last tracked entry and left the real handler stuck on DOM children.

@meta-cla meta-cla Bot added the CLA Signed label Jul 31, 2026
@jackpope
jackpope force-pushed the fragment-refs/fix-remove-event-listener branch from 6b87b51 to 7b40229 Compare July 31, 2026 19:14
@github-actions github-actions Bot added the React Core Team Opened by a member of the React Core Team label Jul 31, 2026
@jackpope
jackpope force-pushed the fragment-refs/fix-remove-event-listener branch from 7b40229 to 2756cca Compare July 31, 2026 20:15
@jackpope
jackpope marked this pull request as ready for review July 31, 2026 21:07
@jackpope
jackpope requested a review from eps1lon July 31, 2026 21:07
@jackpope
jackpope force-pushed the fragment-refs/fix-remove-event-listener branch from 2756cca to 9c71dac Compare August 9, 2026 19:15
Base automatically changed from fragment-refs/scroll-empty-no-warn to main August 11, 2026 03:49
Removing an unregistered listener used splice(-1), which deleted the
last tracked entry and left the real handler stuck on DOM children.
@jackpope
jackpope force-pushed the fragment-refs/fix-remove-event-listener branch from 9c71dac to 6c3c824 Compare August 11, 2026 03:49
@react-sizebot

Copy link
Copy Markdown

Comparing: 3718011...6c3c824

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 7.35 kB 7.35 kB = 1.96 kB 1.96 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 617.53 kB 617.47 kB = 109.41 kB 109.41 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 7.36 kB 7.36 kB = 1.96 kB 1.96 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 688.75 kB 688.69 kB = 120.85 kB 120.86 kB
facebook-www/ReactDOM-prod.classic.js = 708.94 kB 708.88 kB = 124.34 kB 124.35 kB
facebook-www/ReactDOM-prod.modern.js = 699.26 kB 699.19 kB = 122.76 kB 122.77 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 6c3c824

@jackpope
jackpope merged commit 3cba19c into main Aug 12, 2026
238 checks passed
github-actions Bot pushed a commit that referenced this pull request Aug 12, 2026
…7160)

Removing an unregistered listener used splice(-1), which deleted the
last tracked entry and left the real handler stuck on DOM children.

DiffTrain build for [3cba19c](3cba19c)
github-actions Bot pushed a commit that referenced this pull request Aug 12, 2026
…7160)

Removing an unregistered listener used splice(-1), which deleted the
last tracked entry and left the real handler stuck on DOM children.

DiffTrain build for [3cba19c](3cba19c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants