[DOM] Fix Fragment removeEventListener dropping tracked listeners - #37160
Merged
Conversation
jackpope
force-pushed
the
fragment-refs/fix-remove-event-listener
branch
from
July 31, 2026 19:14
6b87b51 to
7b40229
Compare
jackpope
force-pushed
the
fragment-refs/fix-remove-event-listener
branch
from
July 31, 2026 20:15
7b40229 to
2756cca
Compare
jackpope
marked this pull request as ready for review
July 31, 2026 21:07
eps1lon
approved these changes
Jul 31, 2026
jackpope
force-pushed
the
fragment-refs/fix-remove-event-listener
branch
from
August 9, 2026 19:15
2756cca to
9c71dac
Compare
eps1lon
approved these changes
Aug 10, 2026
Removing an unregistered listener used splice(-1), which deleted the last tracked entry and left the real handler stuck on DOM children.
jackpope
force-pushed
the
fragment-refs/fix-remove-event-listener
branch
from
August 11, 2026 03:49
9c71dac to
6c3c824
Compare
|
Comparing: 3718011...6c3c824 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an unregistered listener used splice(-1), which deleted the last tracked entry and left the real handler stuck on DOM children.