Skip to content

[Fiber] Extract Fragment instance commit helpers into their own module - #37167

Merged
jackpope merged 1 commit into
mainfrom
fragment-refs/extract-fragment-instance
Aug 12, 2026
Merged

[Fiber] Extract Fragment instance commit helpers into their own module#37167
jackpope merged 1 commit into
mainfrom
fragment-refs/extract-fragment-instance

Conversation

@jackpope

@jackpope jackpope commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Just a small refactor to consolidate FragmentInstance helpers into one module

@meta-cla meta-cla Bot added the CLA Signed label Jul 31, 2026
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 438e4fc to 503d0d4 Compare July 31, 2026 19:14
@github-actions github-actions Bot added the React Core Team Opened by a member of the React Core Team label Jul 31, 2026
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 503d0d4 to fd7baec Compare July 31, 2026 20:15
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from fd7baec to bd8425c Compare July 31, 2026 20:55
@jackpope
jackpope marked this pull request as ready for review July 31, 2026 21:09
@jackpope
jackpope requested a review from eps1lon July 31, 2026 21:09
@jackpope
jackpope disabled the stack merge August 9, 2026 19:14
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from bd8425c to e02b227 Compare August 9, 2026 19:15
@jackpope
jackpope disabled the stack merge August 11, 2026 03:48
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from e02b227 to b04bc77 Compare August 11, 2026 03:49
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from b04bc77 to a5eb5ed Compare August 12, 2026 00:50
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from a5eb5ed to 360e8b5 Compare August 12, 2026 01:05

@poteto poteto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (light skim). Stacking stamps for the fragment-refs land sequence.

@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 360e8b5 to 3ad6818 Compare August 12, 2026 01:13
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 3ad6818 to 922b5a9 Compare August 12, 2026 01:19
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 922b5a9 to 784b9d0 Compare August 12, 2026 01:25
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from 784b9d0 to f4c8106 Compare August 12, 2026 01:32
Base automatically changed from fragment-refs/portal-child-event-listeners to main August 12, 2026 01:38
Move commit insertion/deletion bookkeeping and fragment ancestry walks
out of ReactFiberCommitHostEffects so placement host-parent logic stays
separate from Fragment instance parent collection.
@jackpope
jackpope force-pushed the fragment-refs/extract-fragment-instance branch from f4c8106 to baa8fd4 Compare August 12, 2026 01:38
@react-sizebot

Copy link
Copy Markdown

Comparing: fdaa617...baa8fd4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 7.35 kB 7.35 kB = 1.96 kB 1.96 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 620.77 kB 620.64 kB = 109.75 kB 109.73 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 7.36 kB 7.36 kB = 1.96 kB 1.96 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 691.98 kB 691.85 kB = 121.25 kB 121.23 kB
facebook-www/ReactDOM-prod.classic.js = 712.17 kB 712.09 kB = 124.73 kB 124.72 kB
facebook-www/ReactDOM-prod.modern.js = 702.49 kB 702.40 kB = 123.15 kB 123.14 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against baa8fd4

@jackpope
jackpope merged commit 22e4f99 into main Aug 12, 2026
238 checks passed
github-actions Bot pushed a commit that referenced this pull request Aug 12, 2026
#37167)

Just a small refactor to consolidate FragmentInstance helpers into one
module

DiffTrain build for [22e4f99](22e4f99)
github-actions Bot pushed a commit that referenced this pull request Aug 12, 2026
#37167)

Just a small refactor to consolidate FragmentInstance helpers into one
module

DiffTrain build for [22e4f99](22e4f99)
github-actions Bot pushed a commit to code/lib-react that referenced this pull request Aug 12, 2026
react#37167)

Just a small refactor to consolidate FragmentInstance helpers into one
module

DiffTrain build for [22e4f99](react@22e4f99)
github-actions Bot pushed a commit to code/lib-react that referenced this pull request Aug 12, 2026
react#37167)

Just a small refactor to consolidate FragmentInstance helpers into one
module

DiffTrain build for [22e4f99](react@22e4f99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants