Update action-hosting-deploy workflow template - #3326
Merged
Conversation
jhuleatt
marked this pull request as ready for review
April 30, 2021 14:11
samtstern
approved these changes
Apr 30, 2021
samtstern
self-requested a review
April 30, 2021 14:20
samtstern
reviewed
Apr 30, 2021
bkendall
approved these changes
Apr 30, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the default workflow template for the Deploy to Firebase Hosting action:
We check to see if a PR is from a fork with:
I found the check in this community post, and @samtstern tested it in google/devlibrary#18
Scenarios Tested
firebase init hosting:githubHere's the diff between the old output of
firebase-hosting-pull-request.ymland the new one: