remove unnecessary src/entry.cloudflare-pages.tsx step

Author: dario-piotrowicz

.changeset/sweet-adults-open.md

@@ -0,0 +1,7 @@
+---
+"create-cloudflare": patch
+---
+
+fix: remove unnecessary step in qwik templates
+
+The step that modifies the `src/entry.cloudflare-pages.tsx` file doesn't seem to change the file in any way anymore, so it's been removed

packages/create-cloudflare/templates/qwik/pages/c3.ts

@@ -24,7 +24,6 @@ const configure = async (ctx: C3Context) => {
 	await runCommand(cmd);
 
 	addBindingsProxy(ctx);
-	populateCloudflareEnv();
 };
 
 const addBindingsProxy = (ctx: C3Context) => {
@@ -89,40 +88,6 @@ const addBindingsProxy = (ctx: C3Context) => {
 	s.stop(`${brandColor("updated")} \`vite.config.ts\``);
 };
 
-const populateCloudflareEnv = () => {
-	const entrypointPath = "src/entry.cloudflare-pages.tsx";
-
-	const s = spinner();
-	s.start(`Updating \`${entrypointPath}\``);
-
-	transformFile(entrypointPath, {
-		visitTSInterfaceDeclaration: function (n) {
-			const b = recast.types.builders;
-			const id = n.node.id as recast.types.namedTypes.Identifier;
-			if (id.name !== "QwikCityPlatform") {
-				this.traverse(n);
-			}
-
-			const newBody = [
-				["env", "Env"],
-				// Qwik doesn't supply `cf` to the platform object. Should they do so, uncomment this
-				// ["cf", "CfProperties"],
-			].map(([varName, type]) =>
-				b.tsPropertySignature(
-					b.identifier(varName),
-					b.tsTypeAnnotation(b.tsTypeReference(b.identifier(type))),
-				),
-			);
-
-			n.node.body.body = newBody;
-
-			return false;
-		},
-	});
-
-	s.stop(`${brandColor("updated")} \`${entrypointPath}\``);
-};
-
 const config: TemplateConfig = {
 	configVersion: 1,
 	id: "qwik",

packages/create-cloudflare/templates/qwik/workers/c3.ts

@@ -27,7 +27,6 @@ const configure = async (ctx: C3Context) => {
 	removeFile("./public/_routes.json");
 
 	addBindingsProxy(ctx);
-	populateCloudflareEnv();
 };
 
 const addBindingsProxy = (ctx: C3Context) => {
@@ -92,40 +91,6 @@ const addBindingsProxy = (ctx: C3Context) => {
 	s.stop(`${brandColor("updated")} \`vite.config.ts\``);
 };
 
-const populateCloudflareEnv = () => {
-	const entrypointPath = "src/entry.cloudflare-pages.tsx";
-
-	const s = spinner();
-	s.start(`Updating \`${entrypointPath}\``);
-
-	transformFile(entrypointPath, {
-		visitTSInterfaceDeclaration: function (n) {
-			const b = recast.types.builders;
-			const id = n.node.id as recast.types.namedTypes.Identifier;
-			if (id.name !== "QwikCityPlatform") {
-				this.traverse(n);
-			}
-
-			const newBody = [
-				["env", "Env"],
-				// Qwik doesn't supply `cf` to the platform object. Should they do so, uncomment this
-				// ["cf", "CfProperties"],
-			].map(([varName, type]) =>
-				b.tsPropertySignature(
-					b.identifier(varName),
-					b.tsTypeAnnotation(b.tsTypeReference(b.identifier(type))),
-				),
-			);
-
-			n.node.body.body = newBody;
-
-			return false;
-		},
-	});
-
-	s.stop(`${brandColor("updated")} \`${entrypointPath}\``);
-};
-
 const config: TemplateConfig = {
 	configVersion: 1,
 	id: "qwik",

packages/wrangler/src/autoconfig/frameworks/qwik.ts

@@ -34,7 +34,6 @@ export class Qwik extends Framework {
 			await runCommand(cmd);
 
 			addBindingsProxy(projectPath);
-			populateCloudflareEnv();
 
 			await addAssetsIgnoreFile(projectPath);
 		}
@@ -133,40 +132,6 @@ function addBindingsProxy(projectPath: string) {
 	s.stop(`${brandColor("updated")} \`vite.config.ts\``);
 }
 
-function populateCloudflareEnv() {
-	const entrypointPath = "src/entry.cloudflare-pages.tsx";
-
-	const s = spinner();
-	s.start(`Updating \`${entrypointPath}\``);
-
-	transformFile(entrypointPath, {
-		visitTSInterfaceDeclaration: function (n) {
-			const b = recast.types.builders;
-			const id = n.node.id as recast.types.namedTypes.Identifier;
-			if (id.name !== "QwikCityPlatform") {
-				this.traverse(n);
-			}
-
-			const newBody = [
-				["env", "Env"],
-				// Qwik doesn't supply `cf` to the platform object. Should they do so, uncomment this
-				// ["cf", "CfProperties"],
-			].map(([varName, type]) =>
-				b.tsPropertySignature(
-					b.identifier(varName),
-					b.tsTypeAnnotation(b.tsTypeReference(b.identifier(type)))
-				)
-			);
-
-			n.node.body.body = newBody;
-
-			return false;
-		},
-	});
-
-	s.stop(`${brandColor("updated")} \`${entrypointPath}\``);
-}
-
 async function addAssetsIgnoreFile(projectPath: string) {
 	const toAdd = ["_worker.js", "_routes.json", "_headers", "_redirects"];