Skip to content

Commit f1017f3

Browse files
C0ZENC0ZEN
authored
fix(dry-run): forbid mutations in dry-run (#500)
Bring back the dry-run by default for the tests - bad idea to disable it sorry Fix bad documentation array format Fixes #499
1 parent b1da9e1 commit f1017f3

4 files changed

Lines changed: 66 additions & 55 deletions

File tree

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ Every argument is optional.
4343
| [remove-stale-when-updated](#remove-stale-when-updated) | Remove stale label from issues/PRs on updates/comments | `true` |
4444
| [remove-issue-stale-when-updated](#remove-issue-stale-when-updated) | Remove stale label from issues on updates/comments | |
4545
| [remove-pr-stale-when-updated](#remove-pr-stale-when-updated) | Remove stale label from PRs on updates/comments | |
46-
| [labels-to-add-when-unstale](#labels-to-add-when-unstale) | Add specified labels from issues/PRs when they become unstale | |
47-
| [labels-to-remove-when-unstale](#labels-to-remove-when-unstale) | Remove specified labels from issues/PRs when they become unstale | |
46+
| [labels-to-add-when-unstale](#labels-to-add-when-unstale) | Add specified labels from issues/PRs when they become unstale | |
47+
| [labels-to-remove-when-unstale](#labels-to-remove-when-unstale) | Remove specified labels from issues/PRs when they become unstale | |
4848
| [debug-only](#debug-only) | Dry-run | `false` |
4949
| [ascending](#ascending) | Order to get issues/PRs | `false` |
5050
| [start-date](#start-date) | Skip stale action for issues/PRs created before it | |

‎__tests__/constants/default-processor-options.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const DefaultProcessorOptions: IIssuesProcessorOptions = Object.freeze({
2525
anyOfIssueLabels: '',
2626
anyOfPrLabels: '',
2727
operationsPerRun: 100,
28-
debugOnly: false,
28+
debugOnly: true,
2929
removeStaleWhenUpdated: false,
3030
removeIssueStaleWhenUpdated: undefined,
3131
removePrStaleWhenUpdated: undefined,

‎dist/index.js‎

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -661,12 +661,14 @@ class IssuesProcessor {
661661
this._consumeIssueOperation(issue);
662662
(_b = this._statistics) === null || _b === void 0 ? void 0 : _b.incrementAddedItemsLabel(issue);
663663
(_c = this._statistics) === null || _c === void 0 ? void 0 : _c.incrementStaleItemsCount(issue);
664-
yield this.client.issues.addLabels({
665-
owner: github_1.context.repo.owner,
666-
repo: github_1.context.repo.repo,
667-
issue_number: issue.number,
668-
labels: [staleLabel]
669-
});
664+
if (!this.options.debugOnly) {
665+
yield this.client.issues.addLabels({
666+
owner: github_1.context.repo.owner,
667+
repo: github_1.context.repo.repo,
668+
issue_number: issue.number,
669+
labels: [staleLabel]
670+
});
671+
}
670672
}
671673
catch (error) {
672674
issueLogger.error(`Error when adding a label: ${error.message}`);
@@ -701,12 +703,14 @@ class IssuesProcessor {
701703
try {
702704
this._consumeIssueOperation(issue);
703705
(_b = this._statistics) === null || _b === void 0 ? void 0 : _b.incrementAddedItemsLabel(issue);
704-
yield this.client.issues.addLabels({
705-
owner: github_1.context.repo.owner,
706-
repo: github_1.context.repo.repo,
707-
issue_number: issue.number,
708-
labels: [closeLabel]
709-
});
706+
if (!this.options.debugOnly) {
707+
yield this.client.issues.addLabels({
708+
owner: github_1.context.repo.owner,
709+
repo: github_1.context.repo.repo,
710+
issue_number: issue.number,
711+
labels: [closeLabel]
712+
});
713+
}
710714
}
711715
catch (error) {
712716
issueLogger.error(`Error when adding a label: ${error.message}`);
@@ -715,12 +719,14 @@ class IssuesProcessor {
715719
try {
716720
this._consumeIssueOperation(issue);
717721
(_c = this._statistics) === null || _c === void 0 ? void 0 : _c.incrementClosedItemsCount(issue);
718-
yield this.client.issues.update({
719-
owner: github_1.context.repo.owner,
720-
repo: github_1.context.repo.repo,
721-
issue_number: issue.number,
722-
state: 'closed'
723-
});
722+
if (!this.options.debugOnly) {
723+
yield this.client.issues.update({
724+
owner: github_1.context.repo.owner,
725+
repo: github_1.context.repo.repo,
726+
issue_number: issue.number,
727+
state: 'closed'
728+
});
729+
}
724730
}
725731
catch (error) {
726732
issueLogger.error(`Error when updating this $$type: ${error.message}`);
@@ -734,14 +740,12 @@ class IssuesProcessor {
734740
try {
735741
this._consumeIssueOperation(issue);
736742
(_a = this._statistics) === null || _a === void 0 ? void 0 : _a.incrementFetchedPullRequestsCount();
737-
if (!this.options.debugOnly) {
738-
const pullRequest = yield this.client.pulls.get({
739-
owner: github_1.context.repo.owner,
740-
repo: github_1.context.repo.repo,
741-
pull_number: issue.number
742-
});
743-
return pullRequest.data;
744-
}
743+
const pullRequest = yield this.client.pulls.get({
744+
owner: github_1.context.repo.owner,
745+
repo: github_1.context.repo.repo,
746+
pull_number: issue.number
747+
});
748+
return pullRequest.data;
745749
}
746750
catch (error) {
747751
issueLogger.error(`Error when getting this $$type: ${error.message}`);

‎src/classes/issues-processor.ts‎

Lines changed: 33 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -740,12 +740,15 @@ export class IssuesProcessor {
740740
this._consumeIssueOperation(issue);
741741
this._statistics?.incrementAddedItemsLabel(issue);
742742
this._statistics?.incrementStaleItemsCount(issue);
743-
await this.client.issues.addLabels({
744-
owner: context.repo.owner,
745-
repo: context.repo.repo,
746-
issue_number: issue.number,
747-
labels: [staleLabel]
748-
});
743+
744+
if (!this.options.debugOnly) {
745+
await this.client.issues.addLabels({
746+
owner: context.repo.owner,
747+
repo: context.repo.repo,
748+
issue_number: issue.number,
749+
labels: [staleLabel]
750+
});
751+
}
749752
} catch (error) {
750753
issueLogger.error(`Error when adding a label: ${error.message}`);
751754
}
@@ -784,12 +787,15 @@ export class IssuesProcessor {
784787
try {
785788
this._consumeIssueOperation(issue);
786789
this._statistics?.incrementAddedItemsLabel(issue);
787-
await this.client.issues.addLabels({
788-
owner: context.repo.owner,
789-
repo: context.repo.repo,
790-
issue_number: issue.number,
791-
labels: [closeLabel]
792-
});
790+
791+
if (!this.options.debugOnly) {
792+
await this.client.issues.addLabels({
793+
owner: context.repo.owner,
794+
repo: context.repo.repo,
795+
issue_number: issue.number,
796+
labels: [closeLabel]
797+
});
798+
}
793799
} catch (error) {
794800
issueLogger.error(`Error when adding a label: ${error.message}`);
795801
}
@@ -798,12 +804,15 @@ export class IssuesProcessor {
798804
try {
799805
this._consumeIssueOperation(issue);
800806
this._statistics?.incrementClosedItemsCount(issue);
801-
await this.client.issues.update({
802-
owner: context.repo.owner,
803-
repo: context.repo.repo,
804-
issue_number: issue.number,
805-
state: 'closed'
806-
});
807+
808+
if (!this.options.debugOnly) {
809+
await this.client.issues.update({
810+
owner: context.repo.owner,
811+
repo: context.repo.repo,
812+
issue_number: issue.number,
813+
state: 'closed'
814+
});
815+
}
807816
} catch (error) {
808817
issueLogger.error(`Error when updating this $$type: ${error.message}`);
809818
}
@@ -818,15 +827,13 @@ export class IssuesProcessor {
818827
this._consumeIssueOperation(issue);
819828
this._statistics?.incrementFetchedPullRequestsCount();
820829

821-
if (!this.options.debugOnly) {
822-
const pullRequest = await this.client.pulls.get({
823-
owner: context.repo.owner,
824-
repo: context.repo.repo,
825-
pull_number: issue.number
826-
});
830+
const pullRequest = await this.client.pulls.get({
831+
owner: context.repo.owner,
832+
repo: context.repo.repo,
833+
pull_number: issue.number
834+
});
827835

828-
return pullRequest.data;
829-
}
836+
return pullRequest.data;
830837
} catch (error) {
831838
issueLogger.error(`Error when getting this $$type: ${error.message}`);
832839
}

0 commit comments

Comments
 (0)