break instead of return

paulshen · paulshen · commit 568ef3e7ea53 · 2019-06-19T11:37:47.000-07:00
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js
@@ -730,11 +730,11 @@ function commitUnmount(current: Fiber): void {
       if (typeof instance.componentWillUnmount === 'function') {
         safelyCallComponentWillUnmount(current, instance);
       }
-      return;
+      break;
     }
     case HostComponent: {
       safelyDetachRef(current);
-      return;
+      break;
     }
     case HostPortal: {
       // TODO: this is recursive.
@@ -745,7 +745,7 @@ function commitUnmount(current: Fiber): void {
       } else if (supportsPersistence) {
         emptyPortalContainer(current);
       }
-      return;
+      break;
     }
     case EventComponent: {
       if (enableEventAPI) {

Original file line number	Diff line number	Diff line change
`@@ -730,11 +730,11 @@ function commitUnmount(current: Fiber): void {`
`730`	`730`	`if (typeof instance.componentWillUnmount === 'function') {`
`731`	`731`	`safelyCallComponentWillUnmount(current, instance);`
`732`	`732`	`}`
`733`		`- return;`
	`733`	`+ break;`
`734`	`734`	`}`
`735`	`735`	`case HostComponent: {`
`736`	`736`	`safelyDetachRef(current);`
`737`		`- return;`
	`737`	`+ break;`
`738`	`738`	`}`
`739`	`739`	`case HostPortal: {`
`740`	`740`	`// TODO: this is recursive.`
`@@ -745,7 +745,7 @@ function commitUnmount(current: Fiber): void {`
`745`	`745`	`} else if (supportsPersistence) {`
`746`	`746`	`emptyPortalContainer(current);`
`747`	`747`	`}`
`748`		`- return;`
	`748`	`+ break;`
`749`	`749`	`}`
`750`	`750`	`case EventComponent: {`
`751`	`751`	`if (enableEventAPI) {`