Commit fb61a1b
authored
fix[ReactDebugHooks/find-primitive-index]: remove some assumptions (#29652)
Partially reverts #28593.
While rolling out RDT 5.2.0, I've observed some issues on React Native
side: hooks inspection for some complex hook trees, like in
AnimatedView, were broken. After some debugging, I've noticed a
difference between what is in frame's source.
The difference is in the top-most frame, where with V8 it will correctly
pick up the `Type` as `Proxy` in `hookStack`, but for Hermes it will be
`Object`. This means that for React Native this top most frame is
skipped, since sources are identical.
Here I am reverting back to the previous logic, where we check each
frame if its a part of the wrapper, but also updated `isReactWrapper`
function to have an explicit case for `useFormStatus` support.1 parent 5bd4031 commit fb61a1b
1 file changed
+18
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
868 | 868 | | |
869 | 869 | | |
870 | 870 | | |
871 | | - | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
872 | 877 | | |
873 | 878 | | |
874 | 879 | | |
| |||
878 | 883 | | |
879 | 884 | | |
880 | 885 | | |
| 886 | + | |
| 887 | + | |
881 | 888 | | |
882 | | - | |
883 | | - | |
884 | | - | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
885 | 897 | | |
886 | 898 | | |
887 | 899 | | |
888 | 900 | | |
889 | 901 | | |
890 | | - | |
891 | | - | |
892 | | - | |
893 | | - | |
894 | | - | |
895 | 902 | | |
| 903 | + | |
896 | 904 | | |
897 | 905 | | |
898 | 906 | | |
| |||
1040 | 1048 | | |
1041 | 1049 | | |
1042 | 1050 | | |
1043 | | - | |
| 1051 | + | |
1044 | 1052 | | |
1045 | 1053 | | |
1046 | 1054 | | |
| |||
0 commit comments