Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 89847bf6e6c0b77ced5dfc7b794c730bb3deac36
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c8bd181095dbddcb6e9d9725b53d51acea382201
Choose a head ref
  • 1 commit
  • 8 files changed
  • 1 contributor

Commits on Apr 21, 2021

  1. Fix: Don't flush discrete at end of batchedUpdates 

    The outermost `batchedUpdates` call flushes pending sync updates at the
end. This was intended for legacy sync mode, but it also happens to
flush discrete updates in concurrent mode.

Instead, we should only flush sync updates at the end of
`batchedUpdates` for legacy roots. Discrete sync updates can wait to
flush in the microtask.

`discreteUpdates` has the same issue, which is how I originally noticed
this, but I'll change that one in a separate commit since it requires
updating a few (no longer relevant) internal tests.
    @acdlite
    acdlite committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c8bd181 View commit details
    Browse the repository at this point in the history
Loading