Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: af19e2eb2f8a849a11d2f5fa98d65d46087058e2
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cb5609099d09fbc5aa5f9ad788ca8af88a7ba610
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on May 14, 2019

  1. Failing test for false positive warning

    @gaearon @acdlite
    gaearon authored and acdlite committed May 14, 2019
    Configuration menu
    Copy the full SHA
    ead0ccc View commit details
    Browse the repository at this point in the history

  2. Flush passive effects before discrete events 

    Currently, we check for pending passive effects inside the `setState`
method before we add additional updates to the queue, in case those
pending effects also add things to the queue.

However, the `setState` method is too late, because the event that
caused the update might not have ever fired had the passive effects
flushed before we got there.

This is the same as the discrete/serial events problem. When a serial
update comes in, and there's already a pending serial update, we have to
do it before we call the user-provided event handlers. Because the event
handlers themselves might change as a result of the pending update.

This commit moves the `flushPassiveEffects` call to before the discrete
event handlers are called, and removes it from the `setState` method.
Non-discrete events will not cause passive effects to flush, which is
fine, since by definition they are not order dependent.
    @acdlite
    acdlite committed May 14, 2019
    Configuration menu
    Copy the full SHA
    cb56090 View commit details
    Browse the repository at this point in the history
Loading