Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bb1d8d166799eb97892be6c7826179270ba283d0
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5e3806d1289d2a74bc0f91cfe463c652b018c20f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 12, 2023

  1. Track the key path difference between right before the first array an…

    …d after
    
    There's a subtle difference if you suspend before the first array or after.
    In Fiber, we don't deal with this because we just suspend the parent and
    replay it if lazy() or Usable are used in its child slots. In Fizz we try
    to optimize this a bit more and enable resuming inside the component.
    
    Semantically, it's different if you suspend/postpone before the first child
    array or inside that child array. Because when you resume the inner result
    might be another array and either that's part of the parent path or part
    of the inner slot.
    
    There might be more clever way of structuring this but I just use -1 to
    indicate that we're not yet inside the array and is in the root child
    position. If that renders an element, then that's just the same as the 0
    slot.
    
    We need to also encode this in the resuming.
    sebmarkbage committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5e3806d View commit details
    Browse the repository at this point in the history
Loading