Skip to content

Commit b7d2bbe

Browse files
committed
fixup! Adding winget workflows
In https://github.com/microsoft/git/actions/runs/20960814462, the workflow printed an unwanted aka.ms URL in the notice. This was because the pattern used to filter the wingetcreate.exe output was too broad and matched any https:// URL. Let's be more specific and only match the actual PR URL pattern: https://github.com/microsoft/winget-pkgs/pull/<number> This ensures that only the relevant pull request URL is captured and displayed in the notice, ignoring aka.ms URLs and other unrelated URLs. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 2a7ba47 commit b7d2bbe

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎.github/workflows/release-winget.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ jobs:
8080
$manifestDirectory = "$PWD\manifests\m\Microsoft\Git\$version"
8181
$output = & .\wingetcreate.exe submit $manifestDirectory
8282
Write-Host $output
83-
$url = ($output | Select-String -Pattern 'https://\S+' | ForEach-Object { $_.Matches.Value })[0]
83+
$url = ($output | Select-String -Pattern 'https://github\.com/microsoft/winget-pkgs/pull/\S+' | ForEach-Object { $_.Matches.Value })[0]
8484
Write-Host "::notice::Submitted ${env:TAG_NAME} to winget as $url"
8585
shell: powershell

0 commit comments

Comments
 (0)